Project

General

Profile

Actions

Bug #91449

closed

Gifbuilder breaks with Security Update (9.5.17); until 9.5.18 performance task

Added by Simon Schmidt almost 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2020-05-20
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Gifbuilder, Serialization
Complexity:
easy
Is Regression:
Sprint Focus:

Description

With security fix 9.5.17, the gifbuilder breaks by loading the serialization in line 722 (https://github.com/TYPO3/TYPO3.CMS/blob/9.5/typo3/sysext/frontend/Classes/Imaging/GifBuilder.php#L722).

After update to 9.5.18, the regression is fixed, but we should also update the code like in TYPO3 10 LTS (see https://review.typo3.org/c/Packages/TYPO3.CMS/+/62234). The implementation is much more faster and you have no more problems with serialization.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #64158: A faster way to generate GIFBUILDER short MD5 hash inside a filenameClosed2015-01-07

Actions
Actions #1

Updated by Simon Schmidt almost 4 years ago

  • Related to Feature #64158: A faster way to generate GIFBUILDER short MD5 hash inside a filename added
Actions #2

Updated by Benni Mack almost 4 years ago

Hey Simon,

I see your point, however we decided not to put this in v9, as the next minor update would re-create a lot of images then (we had a similar issue back in 7.6 with processed images).

Actions #3

Updated by Oliver Bartsch about 3 years ago

  • Status changed from New to Closed

Hi, I'll close this issue now. If you feel, this is the wrong decision, please get in touch with me or directly create a new issue with a reference to this one.

Actions

Also available in: Atom PDF