Task #91509

Switch to json_encode for tx_cms_showpic parameters

Added by Oliver Hader 12 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Security
Target version:
-
Start date:
2020-05-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
hardening
Complexity:
Sprint Focus:

Description

Scalar values sent via HTTP query parameters to ShowImageController are using `json_encode` instead of `unserialize`. The parameter stream is still secured with an HMAC before being deserialized.


Related issues

Related to TYPO3 Core - Bug #91882: ShowImageController throws PHP warning because of #91509Closed2020-07-29

Actions
#1

Updated by Gerrit Code Review 12 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64589

#2

Updated by Gerrit Code Review 12 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64589

#3

Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64608

#4

Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64609

#5

Updated by Oliver Hader 12 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Oliver Hader 12 months ago

  • Tags set to hardening
#7

Updated by Stefan P 10 months ago

  • Related to Bug #91882: ShowImageController throws PHP warning because of #91509 added
#8

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF