Task #91509

Switch to json_encode for tx_cms_showpic parameters

Added by Oliver Hader about 1 month ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Security
Target version:
-
Start date:
2020-05-27
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
hardening
Complexity:
Sprint Focus:

Description

Scalar values sent via HTTP query parameters to ShowImageController are using `json_encode` instead of `unserialize`. The parameter stream is still secured with an HMAC before being deserialized.

Associated revisions

Revision 55fd3c16 (diff)
Added by Oliver Hader about 1 month ago

[TASK] Switch to json_encode for tx_cms_showpic parameters

Scalar values sent via HTTP query parameters to ShowImageController
are using `json_encode` instead of `unserialize`. The parameter
stream is still secured with an HMAC before being deserialized.

Resolves: #91509
Releases: master, 10.4, 9.5
Change-Id: I81b8d5a10a79536592b105c838470238e14b7dca
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64589
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Oliver Hader <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Benni Mack <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Oliver Hader <>

Revision b1810f8e (diff)
Added by Oliver Hader about 1 month ago

[TASK] Switch to json_encode for tx_cms_showpic parameters

Scalar values sent via HTTP query parameters to ShowImageController
are using `json_encode` instead of `unserialize`. The parameter
stream is still secured with an HMAC before being deserialized.

Resolves: #91509
Releases: master, 10.4, 9.5
Change-Id: I81b8d5a10a79536592b105c838470238e14b7dca
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64608
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

Revision 7c89b343 (diff)
Added by Oliver Hader about 1 month ago

[TASK] Switch to json_encode for tx_cms_showpic parameters

Scalar values sent via HTTP query parameters to ShowImageController
are using `json_encode` instead of `unserialize`. The parameter
stream is still secured with an HMAC before being deserialized.

Resolves: #91509
Releases: master, 10.4, 9.5
Change-Id: I81b8d5a10a79536592b105c838470238e14b7dca
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64609
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64589

#2 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64589

#3 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64608

#4 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64609

#5 Updated by Oliver Hader about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Oliver Hader about 1 month ago

  • Tags set to hardening

Also available in: Atom PDF