Project

General

Profile

Actions

Bug #91586

closed

indexer misses to urldecode parsed links when checking for files locally

Added by Henri Nathanson over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Indexed Search
Target version:
-
Start date:
2020-06-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
indexed_search,search,indexer,htmlparser
Complexity:
Is Regression:
Sprint Focus:

Description

The indexer extracts links from a page with HtmlParser and gets urlencoded() uris, which then are not urldecoded() to work in local storage.

https://github.com/TYPO3-CMS/indexed_search/blob/master/Classes/Indexer.php -> extractHyperLinks()

Solution:

'localPath' => $this->createLocalPath(urldecode($tagAttributes[0]['href']))

Possible additional sources:
https://github.com/AOEpeople/crawler/issues/578

Actions #1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64772

Actions #2

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64772

Actions #3

Updated by Jonas Eberle over 4 years ago

Affected: 9, 10, master

I created a patch and set you as author. Thank you :)

Actions #4

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64792

Actions #5

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64793

Actions #6

Updated by Anonymous over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF