Bug #91675
closedProcessed files are not properly re-processed when a crop is defined and the file does not exist
100%
Description
- create and image content element with cropped image
- render frontend
- delete processed file only
- render frontend again
Updated by Helmut Hummel over 4 years ago
- Related to Task #91571: Harden internal state handling added
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64907
Updated by Oliver Hader over 4 years ago
- Related to Feature #65585: Add GUI to enable the editor to set the cropping area for an image added
Updated by Oliver Hader over 4 years ago
- Related to Story #75880: Add art direction capabilities to BE added
Updated by Oliver Hader over 4 years ago
Actually that seems to be a regression from #75880 - prior to that crop
was handled as string and then became the Area
object.
LocalCropScaleMaskHelper::process
gets the configuration array having['crop' => Area(...)]
- it performs a
json_decode(Area::__toString)
in order to retrieve the properties - issue #91571 revealed this design flaw by disallowing arbitrary classes during deserialization
Updated by Helmut Hummel over 4 years ago
Oliver Hader wrote:
Actually that seems to be a regression from #75880 - prior to that
crop
was handled as string and then became theArea
object.
I agree. We can fix the initial regression and json_encode the crop property before serializing the configuration.
That actually was my first approach when working on a fix. However this would invalidate all processed files,
because the configuration hash would change.
Updated by Oliver Hader over 4 years ago
BackendUtility::getThumbnailUrl
(expects JSON) via ThumbnailViewHelper
and does not pass crop
information at all, since it's given as Area
object. This would be another candidate when switching to plain JSON for passing the cropping information...
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64913
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64914
Updated by Helmut Hummel over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset e5c3f707222ef78e91b760848031d398c22b64fe.