Bug #91725

PageLinkBuilder: disableGroupAccessCheck doesn't work for translated pages with fegroup restriction

Added by Markus Müller about 1 year ago. Updated 7 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2020-06-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

corresponding to https://review.typo3.org/c/Packages/TYPO3.CMS/+/64359 there is another issue with linking to translations of restricted pages.

Example (PID 10 is restricted to authenticated users): {f:uri.page(pageUid:'10', linkAccessRestrictedPages:'1')}

Link couldn't be generated because UnableToLinkException is thrown by PageLinkBuilder on line 218 (with fallback type 'strict')

The Problem is in method PageLinkBuilder::build on line 205: a new instance of PageRepository is instantiated, but in Methode PageRpository::getPageOverlay there is no hack like in the workaround above (reset of where_groupAccess in case of $disableGroupAccessCheck === true)


Related issues

Related to TYPO3 Core - Bug #90842: FE user restriction on pages and link incl. linkAccessRestrictedPages create wrong URLsClosed2020-03-26

Actions
#1

Updated by Markus Klein about 1 year ago

  • Related to Bug #90842: FE user restriction on pages and link incl. linkAccessRestrictedPages create wrong URLs added
#2

Updated by Markus Klein 11 months ago

Can you please clarify the initial setup a little more?

What pages do you have (with UIDs), which translations and how does the language site configuration look like?
(This makes reproduction a little more convenient.)

Did you test whether recent versions (10.4.6) are affected too?

#3

Updated by Markus Klein 9 months ago

  • Status changed from New to Accepted
  • Priority changed from Should have to Must have
#4

Updated by Gerrit Code Review 9 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66330

#5

Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66330

#6

Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66330

#7

Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66590

#8

Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66591

#9

Updated by Markus Klein 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#10

Updated by Gerrit Code Review 8 months ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66591

#11

Updated by Markus Klein 8 months ago

  • Status changed from Under Review to Resolved
#12

Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF