Bug #90842

FE user restriction on pages and link incl. linkAccessRestrictedPages create wrong URLs

Added by Tim Lochmüller 13 days ago. Updated 11 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2020-03-26
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hey guys,

I have a page with frontend user restriction and try to link to this page.
The default language link is right, but the links in all other languages are wrong (language segment + default language slug)

Example: (tested with TYPO3 9.5.14)
<f:link.page pageUid="{PID_OF_FE_USER_RESTRICTED_PAGE}" linkAccessRestrictedPages="1">LINK</f:link.page>

Expected result:
DE: /startseite
EN: /en/home

Current result:
The link on a english page is: /en/startseite (the correct language segment, but the default language slug)

Reason:

The function \TYPO3\CMS\Frontend\Typolink\PageLinkBuilder->build respect "linkAccessRestrictedPages" in $disableGroupAccessCheck
but this variable is only used for the page selection AND NOT for the page language overlay in this line: $pageRepository->getPageOverlay($page);

More details:
\TYPO3\CMS\Frontend\Page\PageRepository->getPageOverlaysForLanguageUids uses always this restriction in the selection:
$queryBuilder->setRestrictions(GeneralUtility::makeInstance(FrontendRestrictionContainer::class));

So currently "linkAccessRestrictedPages" is not working with multi language setups.

Any help or ideas for a good solution?

Regards,
Tim


Related issues

Related to TYPO3 Core - Bug #87969: Page route for translated page is not generated correctly when page has frontend group access restrictions Under Review 2019-03-20

History

#1 Updated by Tim Lochmüller 13 days ago

  • Category set to Link Handling, Site Handling & Routing

#2 Updated by Christian Eßl 11 days ago

On it.

#3 Updated by Gerrit Code Review 11 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63963

#4 Updated by Christian Eßl 11 days ago

  • Related to Bug #87969: Page route for translated page is not generated correctly when page has frontend group access restrictions added

#5 Updated by Gerrit Code Review 11 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63963

Also available in: Atom PDF