Bug #90842
closedFE user restriction on pages and link incl. linkAccessRestrictedPages create wrong URLs
100%
Description
Hey guys,
I have a page with frontend user restriction and try to link to this page.
The default language link is right, but the links in all other languages are wrong (language segment + default language slug)
Example: (tested with TYPO3 9.5.14)
<f:link.page pageUid="{PID_OF_FE_USER_RESTRICTED_PAGE}" linkAccessRestrictedPages="1">LINK</f:link.page>
Expected result:
DE: /startseite
EN: /en/home
Current result:
The link on a english page is: /en/startseite (the correct language segment, but the default language slug)
Reason:
The function \TYPO3\CMS\Frontend\Typolink\PageLinkBuilder->build respect "linkAccessRestrictedPages" in $disableGroupAccessCheck
but this variable is only used for the page selection AND NOT for the page language overlay in this line: $pageRepository->getPageOverlay($page);
More details:
\TYPO3\CMS\Frontend\Page\PageRepository->getPageOverlaysForLanguageUids uses always this restriction in the selection:
$queryBuilder->setRestrictions(GeneralUtility::makeInstance(FrontendRestrictionContainer::class));
So currently "linkAccessRestrictedPages" is not working with multi language setups.
Any help or ideas for a good solution?
Regards,
Tim
Updated by Tim Lochmüller almost 5 years ago
- Category set to Site Handling, Site Sets & Routing
Updated by Gerrit Code Review almost 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63963
Updated by Christian Eßl almost 5 years ago
- Related to Bug #87969: Page route for translated page is not generated correctly when page has frontend group access restrictions added
Updated by Gerrit Code Review almost 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63963
Updated by Christian Eßl almost 5 years ago
- Is duplicate of Bug #91045: Language overlay does not respect $disableGroupAccessCheck added
Updated by Jonas Eberle almost 5 years ago
Same as with https://forge.typo3.org/issues/87969 for me:
I can only reproduce in 9.5.15 if linking to a page whose parent is also access restricted.
The incorrect link is then <language prefix of translated language>/<slug of default language>.
Updated by Gerrit Code Review almost 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63963
Updated by Gerrit Code Review almost 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63963
Updated by Gerrit Code Review almost 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64359
Updated by Benni Mack almost 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 56269a975cb2d71bada701796f2c20f2fc68b86e.
Updated by Gerrit Code Review almost 5 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64359
Updated by Benni Mack almost 5 years ago
- Status changed from Under Review to Resolved
Applied in changeset 4978699fe28f6c3a1f820ab2cf028e2ecce7f5b1.
Updated by Benni Mack almost 5 years ago
- Status changed from Resolved to Closed
Updated by Markus Klein over 4 years ago
- Related to Bug #91725: PageLinkBuilder: disableGroupAccessCheck doesn't work for translated pages with fegroup restriction added