Bug #91894: Cast transOrigPointerField value to integer to ensure return type matches - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Bug #91894

closed

Cast transOrigPointerField value to integer to ensure return type matches

Added by Daniel Siepmann over 4 years ago. Updated about 4 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Daniel Siepmann

Category:

Target version:

Candidate for patchlevel

Start date:

2020-07-30

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

When using sqlite, data fetched from DB is not of expected data types.
Therefore some return type hints will break.

In order to not break resolvePreviewRecordId(), there has to be a cast.

This prevents users from editing translated records.

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65139

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65139

Actions

Copy link

Updated by Daniel Siepmann over 4 years ago

Description updated (diff)

Actions

Copy link

Updated by Anja Leichsenring over 4 years ago

how did you find out? Some steps to reproduce the issue would be helpful in testing the change (and yes I realize it is minor). We might run into this root case elsewhere, too.

Actions

Copy link

Updated by Daniel Siepmann over 4 years ago

Sure, sorry.

Translate a record (e.g. tt_content or sys_category).
Use sqlite as DBMS.
Open the edit form of the translated record.

This should result in an error: `Return value of TYPO3\CMS\Backend\Controller\EditDocumentController::resolvePreviewRecordId() must be of the type int, string returned`.

I'm running my website on sqlite for this reason. But only use translations for a specific test right now.
The multiple possible locations are one reason I'm using sqlite. That way I'll find those bugs and can fix them.

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65139

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65111

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65152

Actions

Copy link