Task #91910
closed
Add working default icon for Backend Layout Builder Page TS
100%
Description
When creating a new backend layout record it is possible to show the equivalent page ts config.
This shows something like this:
mod.web_layout.BackendLayouts {
exampleKey {
title = Example
--> icon = EXT:example_extension/Resources/Public/Images/BackendLayouts/default.gif
config {
backend_layout {
colCount = 1
rowCount = 1
rows {
1 {
columns {
1 {
name = 0x0
colPos = 1
}
}
}
}
}
}
}
}
People might forget changing the icon. Add a working icon example to mitigate any errors resulting from that.
Updated by Georg Ringer over 4 years ago
- Status changed from New to Needs Feedback
Thanks for creating the issue. I am wondering: What is the benefit having the path to a working default icon? Important is to have the configuration which works and which can be used modfied later on.
Updated by Nikita Hovratov over 4 years ago
Georg Ringer wrote:
Thanks for creating the issue. I am wondering: What is the benefit having the path to a working default icon? Important is to have the configuration which works and which can be used modfied later on.
Hi Georg, i agree with you. In my case the issue was people copying the configuration and forget to change the icon later on. This led to an error with the mask extension because of the missing icon. So the benefit would be to prevent such cases with either adding a working default icon or completely comment out the icon property.
Updated by Benni Mack about 3 years ago
Hey Nikita,
sure, but did they copy it from the official docs or from somewhere in their other project?
Updated by Nikita Hovratov about 3 years ago
Hey Benni,
it will be suggested to you in the GridEditor:
https://github.com/TYPO3/typo3/blob/29651da70c7ec9f1fe1e829f2a86043880690d8d/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/GridEditor.ts#L294
Create new record -> Backend Layout.
Updated by Gerrit Code Review 6 months ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84529
Updated by Gerrit Code Review 6 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84529
Updated by Gerrit Code Review 5 months ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84752
Updated by Georg Ringer 5 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 103288b971ce6fe27a270e88bab4c31557b1d0b5.
Updated by Gerrit Code Review 5 months ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84752
Updated by Georg Ringer 5 months ago
- Status changed from Under Review to Resolved
Applied in changeset 14242366ae6509435fcab79adce28929f0e7b24c.