Project

General

Profile

Actions
Copy link

Task #92059

closed

Message->isValidHeaderValue uses inefficient string parsing

Added by Claus Due over 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
-
Target version:
-
Start date:
2020-08-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Message->isValidHeaderValue currently uses a combination of "for", "strlen" and "ord" on individual substring offsets to iterate over the bytes of a string.

This is possible to achieve with "unpack" which reduces memory usage and random substring access. Potentially saving thousands of calls to "ord" and one call to "strlen" per header.

Actions
Copy link

Also available in: Atom PDF