Actions
Bug #92313
closedWrongly Hint in method 'getCommandByIdentifier'
Status:
Closed
Priority:
Should have
Assignee:
-
Category:
scheduler
Target version:
-
Start date:
2020-09-15
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Description
The hint `:command` in the function `getCommandByIdentifier` will cause an error, if $this->commands[$identifier] is not defined. PHPStorm mark the 'null' as error
Line 87 in TYPO3\CMS\Core\Console\CommandRegistry
/** * @param string $identifier * @throws CommandNameAlreadyInUseException * @throws UnknownCommandException * @return Command */ public function getCommandByIdentifier(string $identifier): Command { $this->populateCommandsFromPackages(); if (!isset($this->commands[$identifier])) { throw new UnknownCommandException( sprintf('Command "%s" has not been registered.', $identifier), 1510906768 ); } return $this->commands[$identifier] ?? null; }
Updated by Gerrit Code Review about 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65757
Updated by Gerrit Code Review about 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65775
Updated by Georg Ringer about 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9ed135c1121279d745dcecd603acc78be0938b4b.
Actions