Project

General

Profile

Actions

Bug #92362

closed

Bug in regular expression in FormDefinitionConversionService.php

Added by Christian Loth over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2020-09-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Hello,

I think I found a bug in the form sys extension in Classes/Domain/Configuration/FormDefinitionConversionService.php

There is a regular expression in line 57: (^identifier$|renderables\.([\d]+).\identifier$)

The last escape \ escapes the 'i' and not the '.' ... this triggered an error for me
in an installation with custom debugging. I think the correct regular expression should be:

(^identifier$|renderables\.([\d]+)\.identifier$)

The wrong regexp is present in both T3 v9 and v10.

A patch diff file is attached.


Files

form-patch.diff (796 Bytes) form-patch.diff Christian Loth, 2020-09-21 16:45
Actions #1

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66019

Actions #2

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66019

Actions #3

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66032

Actions #4

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66033

Actions #5

Updated by Georg Ringer over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF