Bug #92362
closedBug in regular expression in FormDefinitionConversionService.php
100%
Description
Hello,
I think I found a bug in the form sys extension in Classes/Domain/Configuration/FormDefinitionConversionService.php
There is a regular expression in line 57: (^identifier$|renderables\.([\d]+).\identifier$)
The last escape \ escapes the 'i' and not the '.' ... this triggered an error for me
in an installation with custom debugging. I think the correct regular expression should be:
(^identifier$|renderables\.([\d]+)\.identifier$)
The wrong regexp is present in both T3 v9 and v10.
A patch diff file is attached.
Files
Updated by Gerrit Code Review about 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66019
Updated by Gerrit Code Review about 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66019
Updated by Gerrit Code Review about 4 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66032
Updated by Gerrit Code Review about 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66033
Updated by Georg Ringer about 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 86073064f56fdfbd7da1cee7d4013ea048479811.