Project

General

Profile

Actions

Bug #92405

closed

Sync phpstan rulesets of master and v10

Added by Daniel Goerz about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2020-09-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Since #91635 we have different rulesets for master and v10, which is bad.

Both branches should have the same rulesets as long as we backport phpstan patches.

At the very least v10 must not have rules that master does not have (which is currently the case)


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #91635: Update phpstan to at least 0.12.28ClosedAlexander Schnitzler2020-06-10

Actions
Related to TYPO3 Core - Task #92404: Active phpstan rule IncompatiblePhpDocTypeRuleClosedDaniel Goerz2020-09-25

Actions
Actions #1

Updated by Daniel Goerz about 4 years ago

  • Related to Task #91635: Update phpstan to at least 0.12.28 added
Actions #3

Updated by Daniel Goerz about 4 years ago

  • Related to Task #92404: Active phpstan rule IncompatiblePhpDocTypeRule added
Actions #4

Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65851

Actions #5

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65851

Actions #6

Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65872

Actions #7

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65872

Actions #8

Updated by Anonymous about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF