Bug #92491

ServiceProviderRegistry->create must not have PackageInterface type hinted

Added by Daniel Goerz 10 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2020-10-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Yes
Sprint Focus:

Description

With #92263 the type hint for ServiceProviderRegistry->create() was changed from Package to PackageInterface which is wrong because a method is called that is not part of the interface.


Related issues

Related to TYPO3 Core - Task #92263: Fix phpstan checkFunctionArgumentTypes errors in ext:core DependencyInjectionClosed2020-09-10

Actions
Has duplicate TYPO3 Core - Task #92298: phpstan related changes to DependencyInjection caused wrong type declarationClosed2020-09-13

Actions
#1

Updated by Daniel Goerz 10 months ago

  • Related to Task #92263: Fix phpstan checkFunctionArgumentTypes errors in ext:core DependencyInjection added
#2

Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66057

#3

Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66041

#4

Updated by Daniel Goerz 10 months ago

  • Has duplicate Task #92298: phpstan related changes to DependencyInjection caused wrong type declaration added
#5

Updated by Daniel Goerz 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF