Project

General

Profile

Actions

Bug #92563

closed

Identical slugs: Appendix stops at "-100"

Added by Florian Seirer over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2020-10-14
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If I have more than 100 pages with identical page titles (eg. "test") within the same parent page, the first page gets the slug "test", the second page gets "test-1" and so forth until page #101.
Page #101 doesn't get "test-100" but "test-28a801015d" instead as slug value.

What's even worse: All following pages get the same slug as page #101, making them inaccessible. Regenerating the slug for those pages doesn't really help, it just appends "-" to "test-28a801015d".
I can manually change the slug to "test-100", but editors shouldn't have to worry about this, IMO.

Although that scenario is not a typical use case, I initially found that same behavior with the news extension and its path_segment field on an TYPO3 installation with 25k+ news records. About 300 of them had the exact same slug/path_segment (maybe an error during update to TYPO3 9 from TYPO3 8, i don't know), and only the first 100 records could be fixed.

Different extension, I know, but this lead me to try the same with pages. I could replicate this on TYPO3 9.5.22 using the "create multiple pages"-wizard in the context menu of the page tree.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #91547: Unique slug building fallback is brokenClosed2020-05-31

Actions
Actions #2

Updated by Benni Mack about 3 years ago

  • Related to Bug #91547: Unique slug building fallback is broken added
Actions #3

Updated by Benni Mack over 2 years ago

  • Status changed from New to Needs Feedback

Hey Florian,

what do you expect? The "100" is an internal limit to avoid too many DB queries to check for... otherwise the system might run in a memory limit or execution limit from PHP.

Actions #4

Updated by Florian Seirer over 2 years ago

I don't mind if TYPO3 adds something to the URL.

It's just that some pages become inaccessible because they have the same URL:

  • page # 100: URL = [pagetitle]-99
  • page # 101: URL = [pagetitle]-100
  • page # 102: URL = [pagetitle]-1abf5eab9b
  • page # 103: URL = [pagetitle]-1abf5eab9b
  • page # 104: URL = [pagetitle]-1abf5eab9b
  • page # 105: URL = [pagetitle]-1abf5eab9b
  • ...

In that case nobody can visit page # 103 and above.

But yeah, if that happens you can easily edit the URL, or use better page titles in the first place...

Actions #5

Updated by Benni Mack over 2 years ago

Florian Seirer wrote in #note-4:

In that case nobody can visit page # 103 and above.

But yeah, if that happens you can easily edit the URL, or use better page titles in the first place...

Ha. THANKS, I did not get this from the initial report (stupid me). Will provide a patch!

Actions #6

Updated by Benni Mack over 2 years ago

  • Status changed from Needs Feedback to Accepted
Actions #7

Updated by Benni Mack over 2 years ago

  • Status changed from Accepted to Needs Feedback

Benni Mack wrote in #note-5:

Florian Seirer wrote in #note-4:

In that case nobody can visit page # 103 and above.

But yeah, if that happens you can easily edit the URL, or use better page titles in the first place...

Ha. THANKS, I did not get this from the initial report (stupid me). Will provide a patch!

Hey Florian,

I think this was fixed with #91547 as this now uses a uniqueID() instead of a static md5 hash... https://review.typo3.org/c/Packages/TYPO3.CMS/+/64623 - can you recheck?

Actions #8

Updated by Florian Seirer over 2 years ago

The patch also works für TYPO3 9.5. The URLs are now unique.

Thanks!

Actions #9

Updated by Benni Mack over 2 years ago

  • Status changed from Needs Feedback to Closed

Thanks for the feedback, closing the issue!

Actions

Also available in: Atom PDF