Project

General

Profile

Actions

Bug #92859

closed

Shortcut to ID with own Rootpage/Domain results in 404 (ID outside current Domain)

Added by Gabriel Kaufmann / Typoworx NewMedia over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2020-11-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I can confirm this very annoying bug also on TYPO3 v 9.5.22!

Seems to be related to this bug #92750 pointing out the same issue for TYPO3 v10!


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #92750: Error 404 'ID was outside the domain' for shortcut pointing to other siteClosed2020-11-02

Actions
Actions #1

Updated by Gabriel Kaufmann / Typoworx NewMedia over 3 years ago

  • Related to Bug #92750: Error 404 'ID was outside the domain' for shortcut pointing to other site added
Actions #2

Updated by Gabriel Kaufmann / Typoworx NewMedia over 3 years ago

Okay I've fiddled around trying to find a workaround or bugfix on this.

Middleware 'typo3/cms-frontend/shortcut-and-mountpoint-redirect' (\TYPO3\CMS\Frontend\Middleware\ShortcutAndMountPointRedirect::class) depends on TSFE-Initialization, but logically it should be fired before TSFE because TSFE Handler will handle it as 404.

So I think the Middleware 'typo3/cms-frontend/shortcut-and-mountpoint-redirect' is not ment to handle this "problem", it's a cause somewhere in TSFE Middleware ('typo3/cms-frontend/prepare-tsfe-rendering') as before giving over to 404 Handler there should be checked if it is a Page of Doktype "Shortcut" with external URL.

Actions #3

Updated by Gabriel Kaufmann / Typoworx NewMedia over 3 years ago

Ok here is what i've figured out.

The whole thing is screwed because SiteFinder only works for ONE specific site. Every page which is out of site-scope (current Domain) seems to be ignored.

I think the whole problem is even before TSFE processing! I've been trying to hook in with own Middleware trying to reach the original request (which is currently only possible using $_SERVER) since the original Request is stored no-where. So I only can reach the 404-Request or the Request fallback'ed to Rootsite Pid.

I can't believe nobody thought about Shortcut's which could leave the current Domain.

Actions #4

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Actions #5

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Actions #6

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Actions #7

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Actions #8

Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Actions #9

Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Actions #10

Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Actions #11

Updated by Gerrit Code Review over 2 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Actions #12

Updated by Gerrit Code Review over 2 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Actions #13

Updated by Gerrit Code Review over 2 years ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Actions #14

Updated by Gerrit Code Review over 2 years ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Actions #15

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72582

Actions #16

Updated by Benni Mack over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #17

Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72630

Actions #18

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72582

Actions #19

Updated by Benjamin Franzke over 2 years ago

  • Status changed from Under Review to Resolved
Actions #20

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF