Project

General

Profile

Actions

Bug #93061

closed

flexform sections didn't save when all items are removed

Added by Paul Kamma over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2020-12-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.3
Tags:
flexform section
Complexity:
Is Regression:
Sprint Focus:

Description

When you create a flexform which only contains a section where you can add items then the romoval of all items is not saved.

Example flexform:

<T3DataStructure>
  <ROOT>
    <type>array</type>
    <el>
      <attributes>
        <TCEforms>
          <section>1</section>
          <title>Attribute</title>
          <type>array</type>
          <el>
            <attribute>
                <title>Field</title>
                <type>array</type>
                <el>
                    <label>
                        <TCEforms>
                            <label>Label</label>
                            <config>
                                <type>input</type>
                                <required>1</required>
                            </config>
                        </TCEforms>
                    </label>
                </el>
            </attribute>
          </el>
        </TCEforms>
      </attributes>
    </el>
  </ROOT>
</T3DataStructure>

1. Add a Attribute
2. Save
3. Remove the create Attribute
4. Save
5. Items still there.

When you have an additional field in the flexform which is required (and therefore always existent) the error didn't appear.

I compared the request which is send to the Server between 9 and 10 and in 9 the deleted element also get submitted, in 10 not.


The example screenshots are from different elements but you can see on the second one that the element that gets gets is also included.
I tried to go down the rabbit hole bit but I only noticed that the data which is inside the DataHandler didn't do any flexform check because the pi_flexform data is not available.


Files

Actions #1

Updated by Richard Haeser over 3 years ago

  • Subject changed from flexbox sections didn't save when all items are removed to flexform sections didn't save when all items are removed
Actions #2

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67369

Actions #3

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67369

Actions #4

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67369

Actions #5

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67375

Actions #6

Updated by Andreas Fernandez over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack about 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF