Project

General

Profile

Actions

Bug #93082

closed

EM does not show outdated versions

Added by Thomas Löffler almost 4 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extension Manager
Target version:
-
Start date:
2020-12-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Information about review_state

The field review_state was initially made to set insecure and reviewed extension versions.
Years ago a third state was added, the "outdated" version. This means that this version does not support one of the current supported TYPO3 versions (actually v9 and v10).

States:
  • -1 means insecure
  • -2 means outdated

Problem

Since the rebuilt of the extension index xml file (which EM uses to fetch all extensions) we provided the outdated state. Then some people complained about missing versions to install as they are not displayed anymore when outdated.

In EM there are some repository functions to fetch the versions which checks only for review_state >= 0 to not show insecure versions. But unfortunately it also does not show outdated versions.

Solution?

Add a check for review_state = -2 additionally to the check for review_state >= 0 to show outdated versions again.

Workaround

Currently we have the workaround that the XML file contains no versions with -2 as they are replaced with 0 to show the outdated versions.

Actions #1

Updated by Oliver Bartsch almost 4 years ago

  • Status changed from New to Needs Feedback

AFAIK there are only three possible values for the review_state: 0, -1 and -2. So would changing the constraint from greaterThanOrEqual(0) to in(0,-2) be a suitable solution for you?

Actions #2

Updated by Thomas Löffler almost 4 years ago

Yes, would be suitable.

Actions #3

Updated by Gerrit Code Review 10 months ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82821

Actions #4

Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82821

Actions #5

Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82847

Actions #6

Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82848

Actions #7

Updated by Oliver Bartsch 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF