Task #93246

Check maximum PHP version in entrypoints

Added by Mathias Brodala 7 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Mathias Brodala
Category:
System/Bootstrap/Configuration
Target version:
next-patchlevel
Start date:
2021-01-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The entrypoints for FE, BE and CLI should not only check for a minimum PHP version but also a maximum PHP version. This reflects the composer.json which contains e.g. "php": "^7.4" and thus disallows installation with PHP 8.x.

However, this can accidentally be bypassed if a local development environment uses PHP 7.4 and a remote server uses PHP 8.0.

For this reason an additional check should be added to all entrypoints as safeguard.

Related issues

Related to TYPO3 Core - Bug #93257: Use Composer runtime platform check instead of our ownUnder Review2021-01-10

Actions
#1

Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67365

#2

Updated by Helmut Hummel 7 months ago

  • Related to Bug #93257: Use Composer runtime platform check instead of our own added
#3

Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67365

#4

Updated by Gerrit Code Review 6 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67365

#5

Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67365

#6

Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68617

#7

Updated by Mathias Brodala 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#8

Updated by Gerrit Code Review 4 months ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68617

#9

Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68617

#10

Updated by Mathias Brodala 4 months ago

  • Status changed from Under Review to Resolved
#11

Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF