Bug #93449

ContentObjectRenderer: Dbal compatible field quoting not working for 'leftjoin' and 'rightjoin' - only for 'join'

Added by Ayke Halder 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2021-02-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

The Dbal compatible field quoting in ContentObjectRenderer is not working for leftjoin and rightjoin .

There is a uppercase typo in typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:
must be leftjoin/rightjoin, not leftJoin/rightJoin.

https://github.com/TYPO3-CMS/frontend/blob/2afb96c6725d7751bdb2ca3a53e9566b2eaff52b/Classes/ContentObject/ContentObjectRenderer.php#L5723-L5752

    public function getQuery($table, $conf, $returnQueryArray = false)
    {
[]
        $properties = [
[]
            'join',
            'leftjoin',
            'rightjoin',
[]
        ];
        foreach ($properties as $property) {
[]
            } elseif (in_array($property, ['languageField', 'selectFields', 'join', 'leftJoin', 'rightJoin', 'where'], true)) {
                $conf[$property] = QueryHelper::quoteDatabaseIdentifiers($connection, $conf[$property]);
            }

affected TYPO3 versions

  • master
  • 10.4
  • 9.5
  • 8.7

Documentation

#1

Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67672

#2

Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67694

#3

Updated by Georg Ringer 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#4

Updated by Gerrit Code Review 10 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67695

#5

Updated by Georg Ringer 10 months ago

  • Status changed from Under Review to Resolved
#6

Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF