Bug #93449
closedContentObjectRenderer: Dbal compatible field quoting not working for 'leftjoin' and 'rightjoin' - only for 'join'
100%
Description
The Dbal compatible field quoting in ContentObjectRenderer
is not working for leftjoin
and rightjoin
.
There is a uppercase typo in typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
:
must be leftjoin
/rightjoin
, not leftJoin
/rightJoin
.
public function getQuery($table, $conf, $returnQueryArray = false)
{
[…]
$properties = [
[…]
'join',
'leftjoin',
'rightjoin',
[…]
];
foreach ($properties as $property) {
[…]
} elseif (in_array($property, ['languageField', 'selectFields', 'join', 'leftJoin', 'rightJoin', 'where'], true)) {
$conf[$property] = QueryHelper::quoteDatabaseIdentifiers($connection, $conf[$property]);
}
affected TYPO3 versions¶
- master
- 10.4
- 9.5
- 8.7
Documentation¶
- Dbal Quoting
- select object: property: join/leftjoin/rightjoin
Updated by Gerrit Code Review almost 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67672
Updated by Gerrit Code Review almost 4 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67694
Updated by Georg Ringer almost 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 993c9286a3032bf739e1220b3378fa307098367a.
Updated by Gerrit Code Review almost 4 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67695
Updated by Georg Ringer almost 4 years ago
- Status changed from Under Review to Resolved
Applied in changeset 096b54d078b95bf1eaf7dd7814aca51de9955335.