Task #93516
closed
[BUGFIX] Non admin can't see xMOD_alt_doc.php shortcuts
100%
Description
Prevent id= not found in the url ...returnUrl=*encoded*...
This issue was automatically created from https://github.com/TYPO3/TYPO3.CMS/pull/295
Updated by Gerrit Code Review about 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67921
Updated by Vincent Brechbühler about 3 years ago
Hello,
I saw your comment on my patch and wanted to make it clear.
In fact, here https://git-t3o.typo3.org/TYPO3/CMS/-/blob/10.4/typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php#L525 it checks for a pageId returned by extractPageIdFromShortcutUrl when the user isn't admin but for shortcuts like edit, le pageId is only present in the returnUrl argument so we have to decode the entire shortcut URL for the regex to work.
Thank you !
Vincent
Updated by Gerrit Code Review almost 3 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69758
Updated by Gerrit Code Review almost 3 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69765
Updated by Gerrit Code Review almost 3 years ago
Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69765
Updated by Gerrit Code Review almost 3 years ago
Patch set 3 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69765
Updated by Gerrit Code Review almost 3 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69758
Updated by Gerrit Code Review almost 3 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69758
Updated by Oliver Bartsch almost 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 39392943bb2933007341baa823e082952dd390c7.
Updated by Oliver Bartsch almost 3 years ago
- Is duplicate of Bug #89530: Editors can't create bookmark in filelist added
Updated by Oliver Bartsch almost 3 years ago
- Is duplicate of deleted (Bug #89530: Editors can't create bookmark in filelist)
Updated by Oliver Bartsch almost 3 years ago
- Is duplicate of Bug #89530: Editors can't create bookmark in filelist added
Updated by