Bug #93609
closed
Wrong URL generated by router returned by sitefinder in scheduler task
0%
Description
Given the following page tree:
site1 (site configuration "site1" with domain test.com)
- page1
- page2
site2 (site configuration "site2" with domain example.org)
- page3
- page4
When retrieving the router for page4 in a scheduler task and generating an URL for page3, the site router returns an URL for page1 when using this code:
$siteFinder = GeneralUtility::makeInstance( SiteFinder::class );
$router = $$siteFinder->getSiteByPageId( <ID page4> )->getRouter();
$url = $router->generateUri( <ID page3> );
Result: https://test.com/page1
Expected: https://example.org/page3
Updated by Georg Ringer over 3 years ago
- Status changed from New to Needs Feedback
the PageRouter is always bound to the given site. So my question is: why don't you use
$siteFinder = GeneralUtility::makeInstance( SiteFinder::class ); $router = $$siteFinder->getSiteByPageId( <ID page3> )->getRouter(); $url = $router->generateUri( <ID page3> );
Updated by Aimeos no-lastname-given over 3 years ago
We need to create several page URLs within one site and choose the first page ID to get the router for the site. Creating URLs in the frontend also doesn't require to get the router for every page separately so I would expect it shouls work in the scheduler task the same way.
Updated by Christian Eßl over 1 year ago
Internally, it's the same in the frontend. If you create a link to a typo3 page (from viewhelper, typoscript, LinkFactory, etc.), the linkbuilding will then be passed to PageLinkBuilder, which itself uses the SiteFinder class to fetch the corresponding site to the page id. The router of this site object is then used to finally create the uri.
There is never a case, where the router of another site, that the page id does not belong to, is used to create an uri. (This would create wrong uris)
Updated by Georg Ringer 4 months ago
- Status changed from Needs Feedback to Closed
Hey Norbert,
I am closing this issue as there are no plans to change the routing and as Christian pointed out, also in frontend it works out that way. if you don't agree, feel free to contact me via slack!