Project

General

Profile

Actions

Bug #93893

closed

Link Browser has lost anchor (v10)

Added by Stefan Hekele over 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2021-04-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Yes
Sprint Focus:

Description

In previous TYPO3 versions, when interacting with the page tree in the link browser,
the view automatically jumped back to the place the user interacted with.
This was done by appending an anchor to the URL.

In v10 however, that anchor is no longer being appended to the URL, requiring the user
to manually scroll back to where he was after every click.

The commit introducing this regression was
https://github.com/TYPO3/TYPO3.CMS/commit/04ea328d3f48e680317262f574e3a64abfbc93b8#diff-685d7fdf62249bd66af85c892aa016d39419ba3b0c158d166faff693a2a885c5

As the $anchor variable is still present, the fix is as trivial as appending it to the URL again.

sysext/backend/Classes/Tree/View/ElementBrowserPageTreeView.php::PM_ATagWrap()

return '<a class="list-tree-control ' . ($isOpen ? 'list-tree-control-open' : 'list-tree-control-closed')
            . '" href="' . htmlspecialchars($this->getThisScript() . HttpUtility::buildQueryString($urlParameters)) . '"' . htmlspecialchars($name) . '><i class="fa"></i></a>';

=>

return '<a class="list-tree-control ' . ($isOpen ? 'list-tree-control-open' : 'list-tree-control-closed')
            . '" href="' . htmlspecialchars($this->getThisScript() . HttpUtility::buildQueryString($urlParameters)) . $anchor . '"' . htmlspecialchars($name) . '><i class="fa"></i></a>';

Files

LinkBrowserAnchor.patch (821 Bytes) LinkBrowserAnchor.patch Stefan Hekele, 2021-04-09 11:21
Actions

Also available in: Atom PDF