Bug #93956
closed
TYPO3 v10.15 not handling old Links
100%
Description
Hello,
I updated a typo3 v9.5 installation to typo3 v10.15 yesterday and was experiencing a odd behavior regarding the typoscript menu links. All links got prefixed with mailto:<uid>. I thought nowbody would believe me since i haven't had a similar issue working with typo3 since 15 years. please see my attached screenshot.
I did a bit of debugging and noticed that the type of the link gets detected as type "email" for values like "23", "1306" which is clearly a pageUid and should be treated this way. The reason for this to happen was that in the File typo3_src-10.4.15/typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php (line 74) the validEmail returns true instead of false for value "23". I also did a little check with the following code:
var_dump(\TYPO3\CMS\Core\Utility\GeneralUtility::validEmail((string)parse_url("23", PHP_URL_PATH))); // => true
var_dump(\TYPO3\CMS\Core\Utility\GeneralUtility::validEmail("23")); // => true
I could find out the exact reason for this to happen but switching back to TYPO3 10.14 solved the issue for me. My tests with validEmail returned false after the downgrade.
best regards
Peter
Files
Updated by Sybille Peters over 3 years ago
- Category changed from Linkvalidator to Site Handling, Site Sets & Routing
Hi Peter,
it looks like this is not a linkvalidator, but a linkhandling problem. I changed the category, if this is not correct, please reply.
Updated by Sybille Peters over 3 years ago
Could you write a bit more how this affects you - where are the links and how are they created?
I am not very familiar with the code, maybe someone else can help more. I just noticed you are referring to typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php - the word legacy is always a bit fishy, maybe there is some old link notation which should get converted.
Updated by Markus Klein over 3 years ago
- Status changed from New to Needs Feedback
A few questions:
1.) Is this a composer based installation?
2.) If yes, what is your version of "egulias/email-validator" and "doctrine/lexer" according to your composer.lock file?
I tried around a lot now with v10.4.15, but \TYPO3\CMS\Core\Utility\GeneralUtility::validEmail("23") always results in false.
Updated by Peter Schuhmann over 3 years ago
- % Done changed from 0 to 100
Hi Guys,
thank you for getting back to me so quickly. The menus are generated via typoscript HMENU/TMENU. After switching back to 10.4.14 it worked for a while and than came back I dont know what caused it. I think it was a problem with my local development environment (vagrant) since it crashed a couple of minutes later. After resetting the entire system the problem seems to be vanished. Please close the ticket for now. In case I can reproduce it I will reach out to you guys. thank you.
Best regards
Peter
Updated by Markus Klein over 3 years ago
- Status changed from Needs Feedback to Closed