Bug #94144
closedReturn values of FileReferences getters is null when it should be empty string
100%
Description
In introduced in a project Rector with the code quality rule. In one of my controllers I have the following code:
/* @var FileReference $image */ if ($image->getAlternative()) { // do something }
Rector now changes this condition to:
if ($image->getAlternative() !== '') { // do something }
This is because the @return annotation of the getAlternative() method is set to "string".
But this is not correct as ->getAlternative() can also return null.
The same is with ->getTitle() and ->getDescription().
Updated by Gerrit Code Review over 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69155
Updated by Chris Müller over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 023864e38b13ff097c0ead58a91667037e233904.
Updated by Gerrit Code Review over 3 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70256
Updated by Riccardo De Contardi over 1 year ago
- Status changed from Under Review to Closed
Abandoned for 10.4 -> closing it
If you think that this is the wrong decision or experience the issue again, please reopen it or open a new issue with a reference to this one. Thank you.