Actions
Bug #94144
closedReturn values of FileReferences getters is null when it should be empty string
Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2021-05-17
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
10
PHP Version:
7.4
Tags:
Complexity:
Is Regression:
Sprint Focus:
Description
In introduced in a project Rector with the code quality rule. In one of my controllers I have the following code:
/* @var FileReference $image */ if ($image->getAlternative()) { // do something }
Rector now changes this condition to:
if ($image->getAlternative() !== '') { // do something }
This is because the @return annotation of the getAlternative() method is set to "string".
But this is not correct as ->getAlternative() can also return null.
The same is with ->getTitle() and ->getDescription().
Actions