Bug #94160
closedExtensionComposerStatus breaks in non-composer mode
100%
Description
After upgrading some non-composer instances to 10.4.16 the t3monitoring_client begins to throw an TypeError on the eID request:
(1/1) TypeError Return value of TYPO3\CMS\Extensionmanager\Report\ExtensionComposerStatus::getRequest() must implement interface Psr\Http\Message\ServerRequestInterface, null returned in /****/typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php line 114
I debugged this issue a bit. Here are my findings:
The method getRequest simply returns $GLOBALS['TYPO3_REQUEST']
.
Composer based projects are working fine, they are returning an ServerRequest object:
Non-composer based projects and also the TYPO3-CMS 10.4 branch are returning null
:
Testet the output of the global at Line 114 in typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php while using the t3monitoring_client extension downloaded via TER
https://github.com/TYPO3/TYPO3.CMS/blob/10.4/typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php#L114
Seems strange to me that the glob var behaves differently depending on the composer mode.
Files
Updated by André Buchmann over 3 years ago
- Related to Feature #93931: Add reports modul for composer check added
Updated by Gerrit Code Review over 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69215
Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69215
Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69195
Updated by André Buchmann over 3 years ago
Thank you very much for the quick fix!!! Looking forward to the 10.4.17 release ;-)
Updated by Anonymous over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 72e0faea9cf9b5b84b209e1957167da2a01c1dec.