Bug #94160

ExtensionComposerStatus breaks in non-composer mode

Added by André Buchmann 12 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-05-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

After upgrading some non-composer instances to 10.4.16 the t3monitoring_client begins to throw an TypeError on the eID request:

(1/1) TypeError
Return value of TYPO3\CMS\Extensionmanager\Report\ExtensionComposerStatus::getRequest() must implement interface Psr\Http\Message\ServerRequestInterface, null returned

in /****/typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php line 114

I debugged this issue a bit. Here are my findings:

The method getRequest simply returns $GLOBALS['TYPO3_REQUEST'].

Composer based projects are working fine, they are returning an ServerRequest object:

Non-composer based projects and also the TYPO3-CMS 10.4 branch are returning null:

Testet the output of the global at Line 114 in typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php while using the t3monitoring_client extension downloaded via TER
https://github.com/TYPO3/TYPO3.CMS/blob/10.4/typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php#L114

Seems strange to me that the glob var behaves differently depending on the composer mode.


Files

clipboard-202105191634-obp2o.png (66.7 KB) clipboard-202105191634-obp2o.png André Buchmann, 2021-05-19 14:34
clipboard-202105191636-krce8.png (10.4 KB) clipboard-202105191636-krce8.png André Buchmann, 2021-05-19 14:36

Related issues

Related to TYPO3 Core - Feature #93931: Add reports modul for composer checkClosed2021-04-15

Actions
#1

Updated by André Buchmann 12 months ago

  • Related to Feature #93931: Add reports modul for composer check added
#2

Updated by Gerrit Code Review 12 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69215

#3

Updated by Gerrit Code Review 12 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69215

#4

Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69195

#5

Updated by André Buchmann 12 months ago

Thank you very much for the quick fix!!! Looking forward to the 10.4.17 release ;-)

#6

Updated by Anonymous 12 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF