Project

General

Profile

Actions

Bug #94160

closed

ExtensionComposerStatus breaks in non-composer mode

Added by André Buchmann over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-05-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

After upgrading some non-composer instances to 10.4.16 the t3monitoring_client begins to throw an TypeError on the eID request:

(1/1) TypeError
Return value of TYPO3\CMS\Extensionmanager\Report\ExtensionComposerStatus::getRequest() must implement interface Psr\Http\Message\ServerRequestInterface, null returned

in /****/typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php line 114

I debugged this issue a bit. Here are my findings:

The method getRequest simply returns $GLOBALS['TYPO3_REQUEST'].

Composer based projects are working fine, they are returning an ServerRequest object:

Non-composer based projects and also the TYPO3-CMS 10.4 branch are returning null:

Testet the output of the global at Line 114 in typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php while using the t3monitoring_client extension downloaded via TER
https://github.com/TYPO3/TYPO3.CMS/blob/10.4/typo3/sysext/extensionmanager/Classes/Report/ExtensionComposerStatus.php#L114

Seems strange to me that the glob var behaves differently depending on the composer mode.


Files


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #93931: Add reports modul for composer checkClosed2021-04-15

Actions
Actions

Also available in: Atom PDF