Project

General

Profile

Actions
Copy link

Epic #94254

closed

Enable phpstan rule ReturnTypeRule

Added by Daniel Goerz almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Daniel Goerz
Category:
Code Cleanup
Target version:
-
Start date:
2021-06-02
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Sprint Focus:

Description

ReturnTypeRule is the last disabled rule in level 3 of phpstan. There are about 360 errors to fix.

Let's go.

Subtasks 13 (0 open — 13 closed)

Task #94255: Fix phpstan errors from ReturnTypeRule in EXT:backend,Closed2021-06-02

Actions
Task #94256: Fix phpstan errors from ReturnTypeRule in EXT:belog, EXT:beuser, EXT:dashboard, EXT:extensionmanagerClosed2021-06-02

Actions
Task #94257: Fix phpstan errors from ReturnTypeRule in EXT:extbaseClosed2021-06-02

Actions
Task #94258: Fix phpstan errors from ReturnTypeRule in EXT:core, namespace ResourceClosed2021-06-02

Actions
Task #94259: Fix phpstan errors from ReturnTypeRule in EXT:core, namespace DatabaseClosed2021-06-02

Actions
Task #94260: Fix phpstan errors from ReturnTypeRule in EXT:core, remaining namespacesClosed2021-06-02

Actions
Task #94261: Fix phpstan errors from ReturnTypeRule in EXT:felogin, EXT: filelist, EXT:fluid, Closed2021-06-02

Actions
Task #94262: Fix phpstan errors from ReturnTypeRule in EXT:formClosed2021-06-02

Actions
Task #94263: Fix phpstan errors from ReturnTypeRule in EXT:frontendClosed2021-06-02

Actions
Task #94264: Fix phpstan errors from ReturnTypeRule in EXT:impexp, EXT:indexed_search, EXT:info, EXT:installClosed2021-06-02

Actions
Task #94265: Fix phpstan errors from ReturnTypeRule in EXT:lowlevel, EXT:recordlist, EXT:recycler, EXT: reports, EXT: rte_ckeditorClosed2021-06-02

Actions
Task #94266: Fix phpstan errors from ReturnTypeRule in EXT:scheduler, EXT:tstemplate, EXT:workspacesClosed2021-06-02

Actions
Task #94267: Enable ReturnTypeRule in phpstanClosed2021-06-02

Actions

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #96675: Revamp phpstan config and handlingClosed2022-01-29

Actions
Actions
Copy link
 #1

Updated by Daniel Goerz almost 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Daniel Goerz almost 3 years ago

  • Category changed from Caching to Code Cleanup
Actions
Copy link
 #3

Updated by Christian Kuhn over 2 years ago

  • Related to Task #96675: Revamp phpstan config and handling added
Actions
Copy link
 #4

Updated by Christian Kuhn over 2 years ago

  • Status changed from In Progress to Closed

We changed the strategy to deal with phpstan with #96675. As such, we don't work on rule-by-rule basis anymore, but simply reduce baseline until it is small enough to increase the level. This issue does not make much sense in this workflow anymore, so I'll close it.

Actions
Copy link

Also available in: Atom PDF