Bug #94321
closed
Story #94322: Inconsistencies in showing page TSconfig in Info module
Info => Page TSconfig: Sort order
100%
Description
Update : It is probably better to have the same sort order as in the select list!
Sort order should be case insensitive?
You get
RTE TCEFORM TCEMAIN mod
It might be better to have:
mod RTE TCAdefaults TCEFORM TCEMAIN ...
Especially since the order is different in the select box.
Updated by Sybille Peters over 3 years ago
- Related to Feature #94320: Have collapse / expand in list of page TSconfig in Info module added
Updated by Sybille Peters over 3 years ago
- Related to Story #94322: Inconsistencies in showing page TSconfig in Info module added
Updated by Sybille Peters over 3 years ago
- Subject changed from Info => Page TSconfig: Sort order should be case insensitive? to Info => Page TSconfig: Sort order
- Description updated (diff)
- Parent task set to #94322
Updated by Benni Mack almost 3 years ago
- Status changed from New to Needs Feedback
Hey sybille,
care to create a patch?
Updated by Gerrit Code Review over 1 year ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79165
Updated by Sybille Peters over 1 year ago
Hey sybille, care to create a patch?
The change is no longer as relevant because the rework of the TSconfig module is frankly quite great and does not need much further tweaking (from what I have seen).
The sort order is still case sensitive, but since the items are now collapsed it is not as irritating.
For basic coredev installation it looks like this:
- TCEFORM
- TCEMAIN
- mod
I can try to change the sort order to be case-insensitive (see patch), but I think it would be better to (long term) unify the naming so that the top-level items are all lowercase.
In TypoScript, by convention the type of the "objects" are uppercase (e.g. PAGE) and the "objects" themselves are lowercase. So I think TCEFORM, TCEMAIN etc. should be changed to lowercase. (This sometimes mixing of type and "object" and inconsistent usage of terms is something which was not just noticed and pointed out by me, we already make some changes in the "TypoScript Reference" to address this).
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79165
Updated by Sybille Peters over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1afc9f2fcd80d2d93bdaf86f102c71dcfacda982.