Project

General

Profile

Actions
Copy link

Bug #94343

closed

Internal Server Error in Page Module

Added by Oliver Hader over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

A content element having not CType set, produces an endless loop, causing an internal server error.

→ in PageLayout/Record//Preview.html

<f:render partial="PageLayout/Record/{item.record.CType}/Preview" 
  arguments="{_all}" optional="1">

→ results in PageLayout/Record//Preview
→ is resolved to PageLayout/Record/Preview.html
→ ... which was the initiating partial - endless loop established ...

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #90946: Fluid-based page layout module should render record preview through separate template fileClosed2020-04-04

Actions
Actions
Copy link
 #1

Updated by Oliver Hader over 3 years ago

  • Related to Task #90946: Fluid-based page layout module should render record preview through separate template file added
Actions
Copy link
 #2

Updated by Oliver Hader over 3 years ago

  • Is Regression set to Yes
Actions
Copy link
 #3

Updated by Oliver Hader over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Oliver Hader over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #5

Updated by Oliver Hader over 3 years ago

  • Start date deleted (2021-06-14)
Actions
Copy link
 #6

Updated by Oliver Hader over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #7

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69493

Actions
Copy link
 #8

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69493

Actions
Copy link
 #9

Updated by Oliver Hader over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #10

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69769

Actions
Copy link
 #11

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69769

Actions
Copy link
 #12

Updated by Oliver Hader over 3 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #13

Updated by Anonymous over 3 years ago

This is a breaking change. Declaring it as "BUGFIX" is in my opinion very unhonest. It would at least need the "[!!!]" prefix.

Actions
Copy link
 #14

Updated by Oliver Hader over 3 years ago

Ingo Fabbri wrote in #note-13:

This is a breaking change. Declaring it as "BUGFIX" is in my opinion very unhonest. It would at least need the "[!!!]" prefix.

Wow, "very unhonest" is a strong allegation, as it implies that my only intention was to "destroy" other projects.

Anyway, since we are at this point already:

  • please provide a detailed explanation why it is like that and which scenarios are breaking
  • please provide an alternative solution that would addresses mentioned endless-recursion
Actions
Copy link
 #15

Updated by Benni Mack about 3 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF