Bug #94565: Skip SVG sanitizer test causing segmentation fault - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #94565

closed

Skip SVG sanitizer test causing segmentation fault

Added by Oliver Hader almost 3 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Tests

Target version:

Start date:

2021-07-15

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Test dataset entity.svg is causing segmentation fault in certain scenarios - which might be related to libxml2 before version 2.9.12. Investigations did not reveal further details other than libxml2.

The behavior is triggered with dataset DirtySVG/entity.svg at https://github.com/darylldoyle/svg-sanitizer/blob/beff89576a72540ee99476aeb9cfe98222e76fb8/src/ElementReference/Resolver.php#L87

// in Resolver.php of SVG sanitizer package
$elements = $this->xPath->query('//*[@id]');

→ more details: https://github.com/darylldoyle/svg-sanitizer/issues/52

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Oliver Hader almost 3 years ago

How to test:

apply patch
start Docker environment
in local console execute particular test

Build/Scripts/runTests.sh -s functional \
  -p 7.2 -d sqlite -e '--debug' \
  typo3/sysext/core/Tests/Functional/Resource/Security/SvgSanitizerTest.php

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69894

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69894

Actions

Copy link

Updated by Oliver Hader almost 3 years ago

Description updated (diff)

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69894

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69895

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69896

Actions

Copy link

Updated by Oliver Hader almost 3 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 0e53b48b00a5f110a9ad0c7b44bd08dde2f0ae90.

Actions

Copy link

Updated by Christian Kuhn almost 3 years ago

Related to Task #94582: Skip another SVG sanitizer test causing segmentation fault added

Actions

Copy link

#10

Updated by Christian Kuhn almost 3 years ago

Related to Task #94492: Introduce t3g/svg-sanitizer added

Actions

Copy link

#11

Updated by Gerrit Code Review over 2 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch 11.3 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69975

Actions

Copy link

#12

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch 11.3 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69975

Actions

Copy link

#13