Task #94797: Enhance documentation for integration of html-sanitizer - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #94797

closed

Bug #94787: Tracking issue related to HTML sanitization issues

Enhance documentation for integration of html-sanitizer

Added by Tomas Norre Mikkelsen over 2 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Oliver Hader

Category:

Security

Target version:

Start date:

2021-08-11

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

no-brainer

Sprint Focus:

Description

The example

class MyCustomBuilder extends DefaultSanitizerBuilder implements BuilderInterface
{
    public function createBehavior(): Behavior
    {
        // extends existing behavior, adds new tag
        return parent::createBehavior()
            ->withName('my-custom')
            ->withTags(
                (new Behavior\Tag('my-element', Behavior\Tag::ALLOW_CHILDREN))
                ->addAttrs(
                    (new Behavior\Attr('href'))->addValues(
                        new Behavior\RegExpAttrValue('#^(?:https?://|mailto:)#')
                    ),
                    ...$this->globalAttrs
                )
            );
        }
    }
}

from https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.5.x/Important-94484-IntroduceHTMLSanitizer.html

has one too many } in the example

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70440

Actions

Copy link

Updated by Oliver Hader over 2 years ago

Parent task set to #94787

Actions

Copy link

Updated by Oliver Hader over 2 years ago

Found other things that can be enhanced here...

TypoScript example
information about custom logging

Actions

Copy link

Updated by Oliver Hader over 2 years ago

Tracker changed from Bug to Task
Subject changed from RST Document - To many } in code example for to Enhance documentation for integration of html-sanitizer

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70440

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 11.3 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70417

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70418

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70419

Actions

Copy link

Updated by Tomas Norre Mikkelsen over 2 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 94c1b06babcfa8411fba675caaba0277651b3f64.

Actions

Copy link

#10

Updated by Gerrit Code Review over 2 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70446

Actions

Copy link

#11

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch 11.3 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70417

Actions

Copy link

#12

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70419

Actions

Copy link

#13

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70418

Actions

Copy link

#14