Task #94837: Forward initiator to typo3/html-sanitizer - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #94837

closed

Bug #94787: Tracking issue related to HTML sanitization issues

Forward initiator to typo3/html-sanitizer

Added by Oliver Hader over 2 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Oliver Hader

Category:

Security

Target version:

Start date:

2021-08-12

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

A new SanitizerInitiator is added and forwarded to typo3/html-sanitizer. This allows to get a full stack-trace when HTML nodes have been sanitized/modified and allows to debug the actual cause (initiator) much better.

How to test?¶

composer req typo3/html-sanitizer:dev-main
- (or manually clone into vendor/typo3/html-sanitizer directory from https://github.com/TYPO3/html-sanitizer)
apply patch from https://review.typo3.org/c/Packages/TYPO3.CMS/+/70484 (TYPO3 v10.4 currently)
have logging enabled as described in https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.5.x/Important-94484-IntroduceHTMLSanitizer.html#debugging-logging
have debugging enabled via TypoScript, like config.debug = 1

In case tags/attrs are modified, this will be shown in the log file, next to new initiator stack-trace.

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from New to Under Review

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70484

Actions

Copy link

Updated by Oliver Hader over 2 years ago

Description updated (diff)

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70484

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70490

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70490

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70484

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 11.3 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70509

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70510

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70510

Actions

Copy link

#10