Bug #95111: "Feature Toggles" with file OPcaching disabled doesn't work - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #95111

closed

"Feature Toggles" with file OPcaching disabled doesn't work

Added by Davide Alghi over 2 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Install Tool

Target version:

Start date:

2021-09-05

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.4

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

"Feature Toggles", in "ADMIN TOOLS>Settings" module, has saving problems, if file OPcaching is disabled (opcache.file_update_protection=0).
The "typo3conf/LocalConfiguration.php" file is not updated correctly.
This problem was already reported #59662

The "featuresSave" action, in the "Settings" controller for "install" system extension, loops over all available features and creates/saves LocalConfiguration file for each feature.
If OPcache is enabled and file caching is disabled, each save overwrites the previous one, but with initial features configuration values.

My opinion
"featuresSave" action should save LocalConfiguration file atomically, as "Configure Installation-Wide Options" does via "ConfigurationManager::setLocalConfigurationValuesByPathValuePairs()"

PS: I have selected TYPO3 v11, but the problem also exists in TYPO3 v9 and v10

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Davide Alghi over 2 years ago

I added my proposal to fix this

https://github.com/TYPO3/typo3/pull/318

Actions

Copy link

Updated by Georg Ringer over 2 years ago

Related to Bug #59662: Problem with subsequent calls to $configurationManager->setLocalConfigurationValueByPath and 'LocalConfiguration invalid' added

Actions

Copy link

Updated by Simon Schaufelberger over 2 years ago

Related to Task #95112: Featuretoggles added

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70896

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70896

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70896

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70896

Actions

Copy link