Project

General

Profile

Actions

Bug #95572

closed

TCA selectSingle with foreign_table and selicon_field does not find images

Added by Lina Wolf about 3 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2021-10-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you install the current master with the extension styleguide have a look at table tx_styleguide_elements_select, field select_single_12 the images do not get displayed. While we where doing automatic screenshots for TYPO3 11.4 this still worked. See screenshots attached.


Files

SelectSingle12-master.png (9.08 KB) SelectSingle12-master.png Lina Wolf, 2021-10-11 19:49
SelectSingle12-11.4.png (50.7 KB) SelectSingle12-11.4.png Lina Wolf, 2021-10-11 19:49

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #97442: Icon form Backend Layout Record are broken in SidesettingsClosed2022-04-21

Actions
Related to TYPO3 Core - Task #95027: Always generate absolute FAL URLs in the backendClosed2021-08-29

Actions
Actions #1

Updated by Georg Ringer about 3 years ago

  • Status changed from New to Accepted
Actions #2

Updated by Georg Ringer about 3 years ago

Some more debugging information:

while static select icons have a syntax like 'EXT:styleguide/Resources/Public/Icons/tx_styleguide.svg', icons of releations using ctrl|selicon_field have a path like /fileadmin/styleguide/telephone_box.jpg which is created in

AbstractItemProvider

if ($isReferenceField) {
                    $references = $fileRepository->findByRelation($foreignTable, $iconFieldName, $foreignRow['uid']);
                    if (is_array($references) && !empty($references)) {
                        $icon = reset($references);
                        $icon = $icon->getPublicUrl();
                    }
                }

later in \TYPO3\CMS\Backend\Form\Utility\FormEngineUtility::getIconHtml the line

$absoluteFilePath = GeneralUtility::getFileAbsFileName($icon);

will transform the fileadmin path into an empty string and the icon can be retrieved

Actions #3

Updated by Oliver Bartsch over 2 years ago

  • Related to Bug #97442: Icon form Backend Layout Record are broken in Sidesettings added
Actions #4

Updated by Nikita Hovratov almost 2 years ago

  • Related to Task #95027: Always generate absolute FAL URLs in the backend added
Actions #5

Updated by Nikita Hovratov almost 2 years ago

Found causing commit through git bisect: #95027

Actions #6

Updated by Nikita Hovratov almost 2 years ago

The difference is the prefixed slash in /fileadmin/styleguide/telephone_box.jpg
Without the slash it works again: fileadmin/styleguide/telephone_box.jpg

Actions #7

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77208

Actions #8

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77208

Actions #9

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77208

Actions #10

Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77431

Actions #11

Updated by Nikita Hovratov almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Benni Mack almost 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF