Project

General

Profile

Actions
Copy link

Bug #95878

open

In linkvalidator, soft reference parser extracts 2 links from rich text with URL as anchor text

Added by Sybille Peters about 3 years ago. Updated about 1 month ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2021-11-05
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

This used to work fine. This seems to be not a bug in linkvalidator but due to a change in link parsing!

Reproduce

1. Create a CE (e.g. textmedia) and create a link in the bodytext (RTE) using an URL as link text (e.g. http://localhost/i-am-broken)
2. The generated code in RTE will be like <a href="http://localhost/i-am-broken">http://localhost/i-am-broken</a>
3. Execute "Check links" in "Info" > "Linkvalidator" > "Check links" tab

The problem does not occur, if it is just the URL in RTE, not with link markup:

Actual result

2 Broken link records will be displayed for this broken link

Expected result

Only one record should be displayed for 1 broken link.

Reason of problem

Since there are several softrefparsers for the field ($conf['softref'] = 'typolink_tag,email[subst],url') the text is parsed several times and if there is a match, this part is not removed (which it probably should).

Result:

$conf['softref'] = 'typolink_tag,email[subst],url'

<a href="https://blah">https://blah</a>

(1)
softReferenceParser
 parserKey=typolink_tag

 parserResult:
   matchstring=<a href="https://blah">
   type=external
   tokenValue=https://blah

(2)
 softReferenceParser
  parserKey=url

 parserResult:
    matchString=https://blah
    type=string
    value=https://blah

Files

Download all files
linkvalidator_result.png (32 KB) linkvalidator_result.png Sybille Peters, 2024-03-15 07:46
linkvalidator_rte.png (11.4 KB) linkvalidator_rte.png Sybille Peters, 2024-03-15 07:46
linkvalidator_rte2.png (11.5 KB) linkvalidator_rte2.png Sybille Peters, 2024-03-15 07:51

Related issues 7 (2 open — 5 closed)

Related to TYPO3 Core - Bug #94920: "Register SoftReference parsers via DI breaks" breaks backendClosed2021-08-18

Actions
Related to TYPO3 Core - Bug #95449: Linkvalidator no longer detects broken links in pages.urlClosed2021-10-02

Actions
Related to TYPO3 Core - Task #94687: Deprecate SoftReferenceIndexClosed2021-08-02

Actions
Related to TYPO3 Core - Bug #95676: Broken external link count is wrongClosed2021-10-17

Actions
Related to TYPO3 Core - Bug #98120: Link parsing problem in linkvalidator Closed2022-08-10

Actions
Related to TYPO3 Core - Bug #98328: Exception "Data too long for column url" when checking links New2022-09-11

Actions
Related to TYPO3 Core - Bug #99909: False positive broken links by parsing URLs not inside <a> tagsNeeds Feedback2023-02-09

Actions
Actions
Copy link
 #1

Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #2

Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #3

Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #4

Updated by Gerrit Code Review about 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #5

Updated by Gerrit Code Review about 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #6

Updated by Gerrit Code Review about 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #7

Updated by Gerrit Code Review about 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #8

Updated by Gerrit Code Review about 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #9

Updated by Nikita Hovratov about 3 years ago

  • Related to Bug #94920: "Register SoftReference parsers via DI breaks" breaks backend added
Actions
Copy link
 #10

Updated by Sybille Peters about 3 years ago

  • Description updated (diff)
Actions
Copy link
 #11

Updated by Sybille Peters about 3 years ago

  • Related to Bug #95449: Linkvalidator no longer detects broken links in pages.url added
Actions
Copy link
 #12

Updated by Sybille Peters about 3 years ago

  • Related to Task #94687: Deprecate SoftReferenceIndex added
Actions
Copy link
 #13

Updated by Sybille Peters about 3 years ago

  • File deleted (linkvalidator_notes.txt)
Actions
Copy link
 #14

Updated by Sybille Peters about 3 years ago

  • Description updated (diff)
Actions
Copy link
 #15

Updated by Sybille Peters about 3 years ago

  • Is Regression set to Yes
Actions
Copy link
 #16

Updated by Stefan Bürk about 3 years ago

  • Related to Bug #95676: Broken external link count is wrong added
Actions
Copy link
 #17

Updated by Gerrit Code Review about 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #18

Updated by Gerrit Code Review about 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #19

Updated by Gerrit Code Review almost 3 years ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #20

Updated by Gerrit Code Review almost 3 years ago

Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #21

Updated by Sybille Peters over 2 years ago

  • Related to Bug #98120: Link parsing problem in linkvalidator added
Actions
Copy link
 #22

Updated by Sybille Peters about 2 years ago

  • Related to Bug #98328: Exception "Data too long for column url" when checking links added
Actions
Copy link
 #23

Updated by Sybille Peters over 1 year ago

  • Related to Bug #99909: False positive broken links by parsing URLs not inside <a> tags added
Actions
Copy link
 #24

Updated by Gerrit Code Review 10 months ago

Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #25

Updated by Gerrit Code Review 10 months ago

Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #26

Updated by Gerrit Code Review 10 months ago

Patch set 15 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link
 #28

Updated by Sybille Peters 8 months ago

Actions
Copy link
 #29

Updated by Gerrit Code Review about 1 month ago

Patch set 16 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Actions
Copy link

Also available in: Atom PDF