Bug #95878

In linkvalidator, soft reference parser extracts 2 links from rich text with URL as anchor text

Added by Sybille Peters 3 months ago. Updated 15 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2021-11-05
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Reproduce

1. Create a CE (e.g. textmedia) and enter an URL (e.g. https://blah) and enter in the rich text (e.g. tt_content.bodytext)
2. The generated code in RTE will be like <a href="https://blah">https://blah</a>
3. Execute "Check links" in "Info" > "Linkvalidator" > "Check links" tab

Actual result

2 Broken link records will be displayed for this broken link

Expected result

Only one record should be displayed for 1 broken link.

Reason of problem

Since there are several softrefparsers for the field ($conf['softref'] = 'typolink_tag,email[subst],url') the text is parsed several times and if there is a match, this part is not removed (which it probably should).

Result:

$conf['softref'] = 'typolink_tag,email[subst],url'

<a href="https://blah">https://blah</a>

(1)
softReferenceParser
 parserKey=typolink_tag

 parserResult:
   matchstring=<a href="https://blah">
   type=external
   tokenValue=https://blah

(2)
 softReferenceParser
  parserKey=url

 parserResult:
    matchString=https://blah
    type=string
    value=https://blah


Related issues

Related to TYPO3 Core - Bug #94920: "Register SoftReference parsers via DI breaks" breaks backendClosed2021-08-18

Actions
Related to TYPO3 Core - Bug #95449: Linkvalidator no longer detects broken links in pages.urlResolved2021-10-02

Actions
Related to TYPO3 Core - Task #94687: Deprecate SoftReferenceIndexClosed2021-08-02

Actions
Related to TYPO3 Core - Bug #95676: Broken external link count is wrongClosed2021-10-17

Actions
#1

Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

#2

Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

#3

Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

#4

Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

#5

Updated by Gerrit Code Review 2 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

#6

Updated by Gerrit Code Review 2 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

#7

Updated by Gerrit Code Review 2 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

#8

Updated by Gerrit Code Review 2 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

#9

Updated by Nikita Hovratov 2 months ago

  • Related to Bug #94920: "Register SoftReference parsers via DI breaks" breaks backend added
#10

Updated by Sybille Peters 2 months ago

  • Description updated (diff)
#11

Updated by Sybille Peters 2 months ago

  • Related to Bug #95449: Linkvalidator no longer detects broken links in pages.url added
#12

Updated by Sybille Peters 2 months ago

  • Related to Task #94687: Deprecate SoftReferenceIndex added
#13

Updated by Sybille Peters 2 months ago

  • File deleted (linkvalidator_notes.txt)
#14

Updated by Sybille Peters 2 months ago

  • Description updated (diff)
#15

Updated by Sybille Peters 2 months ago

  • Is Regression set to Yes
#16

Updated by Stefan Bürk 2 months ago

  • Related to Bug #95676: Broken external link count is wrong added
#17

Updated by Gerrit Code Review 2 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

#18

Updated by Gerrit Code Review 2 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

#19

Updated by Gerrit Code Review about 2 months ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

#20

Updated by Gerrit Code Review 15 days ago

Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057

Also available in: Atom PDF