Bug #95878
open
In linkvalidator, soft reference parser extracts 2 links from rich text with URL as anchor text
0%
Description
This used to work fine. This seems to be not a bug in linkvalidator but due to a change in link parsing!
Reproduce¶
1. Create a CE (e.g. textmedia) and create a link in the bodytext (RTE) using an URL as link text (e.g. http://localhost/i-am-broken)
2. The generated code in RTE will be like <a href="http://localhost/i-am-broken">http://localhost/i-am-broken</a>
3. Execute "Check links" in "Info" > "Linkvalidator" > "Check links" tab
The problem does not occur, if it is just the URL in RTE, not with link markup:
Actual result¶
2 Broken link records will be displayed for this broken link
Expected result¶
Only one record should be displayed for 1 broken link.
Reason of problem¶
Since there are several softrefparsers for the field ($conf['softref'] = 'typolink_tag,email[subst],url') the text is parsed several times and if there is a match, this part is not removed (which it probably should).
Result:
$conf['softref'] = 'typolink_tag,email[subst],url'
<a href="https://blah">https://blah</a>
(1)
softReferenceParser
parserKey=typolink_tag
parserResult:
matchstring=<a href="https://blah">
type=external
tokenValue=https://blah
(2)
softReferenceParser
parserKey=url
parserResult:
matchString=https://blah
type=string
value=https://blah
Files
Updated by Gerrit Code Review over 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review over 2 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review over 2 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review over 2 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review over 2 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review over 2 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review over 2 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review over 2 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Nikita Hovratov over 2 years ago
- Related to Bug #94920: "Register SoftReference parsers via DI breaks" breaks backend added
Updated by Sybille Peters over 2 years ago
- Related to Bug #95449: Linkvalidator no longer detects broken links in pages.url added
Updated by Sybille Peters over 2 years ago
- Related to Task #94687: Deprecate SoftReferenceIndex added
Updated by Sybille Peters over 2 years ago
- File deleted (
linkvalidator_notes.txt)
Updated by Stefan Bürk over 2 years ago
- Related to Bug #95676: Broken external link count is wrong added
Updated by Gerrit Code Review over 2 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review over 2 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review over 2 years ago
Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review over 2 years ago
Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Sybille Peters over 1 year ago
- Related to Bug #98120: Link parsing problem in linkvalidator added
Updated by Sybille Peters over 1 year ago
- Related to Bug #98328: Exception "Data too long for column url" when checking links added
Updated by Sybille Peters 9 months ago
- Related to Bug #99909: False positive broken links by parsing URLs not inside <a> tags added
Updated by Gerrit Code Review 3 months ago
Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review 3 months ago
Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Gerrit Code Review 3 months ago
Patch set 15 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72057
Updated by Sybille Peters about 1 month ago
- File linkvalidator_result.png linkvalidator_result.png added
- File linkvalidator_rte.png linkvalidator_rte.png added
- Description updated (diff)
Updated by Sybille Peters about 1 month ago
- File linkvalidator_rte2.png linkvalidator_rte2.png added
- Description updated (diff)