TYPO3 Core

Just checked this in current master and can confirm. The reason is the regex, which does not match the quoted expression:

https://github.com/TYPO3/typo3/blob/master/typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php#L868

I checked with following foreign_table_where: ORDER BY {#pages}.{#sorting}.

After quoting (https://github.com/TYPO3/typo3/blob/master/typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php#L743), in my case this is ORDER BY `pages`.`sorting` and therefore does not match the regex.

However, even if the regex would be extended for the possible quoting characters, the result would be quoted again, on being added to the query:

https://github.com/TYPO3/typo3/blob/master/typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php#L652

This then also results in invalid SQL. In my case:

ORDER BY ```pages```.```sorting``` ASC

Hi Stefan,

after checking this again, I think this currently works as intended. Both ORDER BY as well as GROUP BY should NOT be quoted in TCA as quoting is always applied through the API:

• For ORDER BY: https://github.com/TYPO3/typo3/blob/master/typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php#L646
• For GROUP BY: https://github.com/TYPO3/typo3/blob/master/typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php#L640

Actually, the docs also mention this:

[...] Note that the ORDER BY is NOT quoted since that is parsed out anyway and always receives proper quoting.

https://docs.typo3.org/m/typo3/reference-tca/master/en-us/ColumnsConfig/Type/Select/Properties/ForeignTableWhere.html#field-quoting

I anyways added a PR (https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-TCA/pull/489) for the docs, to make this a bit more clear and will therefore close this issue now.

In case there is still something not working correctly, or you encounter a similar problem, please contact me or create a new issue with reference to this one.