Project

General

Profile

Actions

Bug #96356

closed

Performance LiveSearch for admin users

Added by Stefan Froemken almost 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Performance
Target version:
Start date:
2021-12-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hello,

searching for any value in LiveSearch as Admin is very slow.

I found these lines of code which are very slow:

$mounts = $GLOBALS['BE_USER']->returnWebmounts();
foreach ($mounts as $pageId) {
    $pageList[] = $this->getAvailablePageIds($pageId, self::RECURSIVE_PAGE_LEVEL);
}

We have a pagetree with over 65.000 pages. As Admin user I can access each page of them. IMO there is no need to check webmounts and extract all pages from pages-tree. I think it would be easier to remove the Query-part against "pid", if an admin uses the search.

I will create a patch for that.

Stefan

Actions #1

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72661

Actions #2

Updated by Stefan Froemken almost 3 years ago

Tested with following query string: "#22690"
on a system with more than 30.000 pages

Without this patch: 14.3 seconds
With patch: 105ms

Actions #3

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72661

Actions #4

Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72884

Actions #5

Updated by Stefan Froemken almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF