Bug #96509
closed
Vimeo Online Media helper fetches incorrect media ID from embed snippet
100%
Description
The Vimeo Online Media Helper tries to extract the media ID from various types of vimeo URLs. The regular expression was modified to support event type URLs and at that moment a bug was introduced that included the leading slash in the media ID.
Updated by Oliver Hader almost 3 years ago
Do you have an issue number which introduced that regular expression you mentioned?
Can you please post the Vimeo ID or URL you have been using (just to see the format/structure)?
Updated by Oliver Hader almost 3 years ago
Are you referring to this change?
https://review.typo3.org/c/Packages/TYPO3.CMS/+/69953/2/typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/VimeoHelper.php
Currently
...(?:video|event\/)...
Should have been (allowing either video/ or event/)
...(?:video\/|event\/)...
Updated by Oliver Hader almost 3 years ago
- Status changed from New to Accepted
- Start date deleted (
2022-01-11)
https://regex101.com/r/uLXbGA/1 shows the problem - and that the ID 7215347324/hasf8a65sdsa7d now has that leading slash /7215347324/hasf8a65sdsa7d
Introduced for v11.4.0 and v10.4.20
→ https://review.typo3.org/q/I8c074372c3c42b8c5a74afff7b9fb386c2f136a2
Updated by Gerrit Code Review almost 3 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72967
Updated by Jigal van Hemert almost 3 years ago
Oliver Hader wrote in #note-3:
https://regex101.com/r/uLXbGA/1 shows the problem - and that the ID
7215347324/hasf8a65sdsa7dnow has that leading slash/7215347324/hasf8a65sdsa7dIntroduced for v11.4.0 and v10.4.20
→ https://review.typo3.org/q/I8c074372c3c42b8c5a74afff7b9fb386c2f136a2
Yes, the '\/' was missing after the "video" part.
Updated by Gerrit Code Review almost 3 years ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72968
Updated by Gerrit Code Review almost 3 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72969
Updated by Oliver Hader almost 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0e0524b5a9557b925b988f522579042251e146d6.
Updated by