Project

General

Profile

Actions

Task #96520

closed

Enforce non-empty configuration in ContentObjectRenderer::parseFunc

Added by Oliver Hader over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2022-01-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Invoking ContentObjectRenderer::parseFunc without passing any configuration or a reference to some rendering instruction, in general does not make much sense.

Calling this method without any instructions led to various side-effects, e.g. unintentionally enforcing typo3/html-sanitizer. This problem was amplified when using <f:format.html parseFuncTSPath=""> with an explicitly empty reference which actually did not do anything and behaved the same as <f:format.raw> .

This change enforces that parseFunc is only invoked with actual instructions. An empty configuration will throw a LogicException and requires corresponding source code or Fluid templates to be adjusted.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #94786: Relax behavior of HTML sanitizationClosedOliver Hader2021-08-10

Actions
Actions #1

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72997

Actions #2

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72997

Actions #3

Updated by Oliver Hader over 2 years ago

  • Description updated (diff)
Actions #4

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72997

Actions #5

Updated by Oliver Hader over 2 years ago

  • Description updated (diff)
Actions #6

Updated by Oliver Hader over 2 years ago

  • Description updated (diff)
Actions #7

Updated by Oliver Hader over 2 years ago

  • Related to Bug #94786: Relax behavior of HTML sanitization added
Actions #8

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72997

Actions #9

Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72997

Actions #10

Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72997

Actions #11

Updated by Gerrit Code Review about 2 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72997

Actions #12

Updated by Gerrit Code Review about 2 years ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72997

Actions #13

Updated by Oliver Hader about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #14

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF