Project

General

Profile

Actions

Bug #96722

closed

Image cropping area cannot always expand to full image size

Added by Alexander Nitsche almost 3 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Image Cropping
Target version:
Start date:
2022-02-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

It depends on the browser window size if the image cropping area can be expanded to the full image size or only to full size minus one. It should be always possible to expand it to full size.

Steps to reproduce

  1. Resize your browser window to width of 1100px via the browser developer tools.
  2. Log into TYPO3 backend.
  3. Create a common "Text & Media" content element on a page.
  4. Add the image t3docs-report-2021-disable-dummy-url.png in the Media tab to the content element.
  5. Open the image manipulation overlay by Image Manipulation > Open Editor .
  6. Confirm that the height of the cropping area is set to 23px - the dimension is displayed in the sidebar on the right.
  7. Drag the cropping area to full image height.
  8. Confirm that the height is still set to 23px, although the full image height is 24px.

When performing the same steps with an initial browser window width of 1200px, the cropping area can be set to the full height of 24 px.

Findings

This seems to be a pixel rounding issue of position and dimension in Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ImageManipulation.ts:cropMoveHandler(): The incoming Cropper event might not hand in the full image height, but the full image height minus a minimal fraction, e.g.

(1) t3docs-report-2021-disable-dummy-url.png with website resolution 1100 x 400px and cropping area expanded to full height (24px):
---
event { type: "crop", x: 0, y: 0, width: 194, height: 23.999999999999996, rotate: 0, scaleX: 1, scaleY: 1, .. }
---

(2) t3docs-report-2021-disable-dummy-url.png with website resolution 1200 x 400px and cropping area expanded to full height (24px):
---
event { type: "crop", x: 0, y: 0, width: 194, height: 24, rotate: 0, scaleX: 1, scaleY: 1, .. }
---

The event handler cropMoveHandler() probably has to replace Math.floor() with Math.round() in some places and make sure, that the size can never exceed the image size.


Files

Actions #1

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78717

Actions #2

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78769

Actions #3

Updated by Andreas Fernandez over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF