Project

General

Profile

Actions

Task #96725

closed

Use generics for ObjectProphecy class properties

Added by Benjamin Franzke about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2022-02-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

With #96713 all type annotations on class properties
in tests have been reduced to ObjectProphecy only,
removing the information which class or interface
is mocked.

The jangregor/phpstan-prophecy plugin defines ObjectProphecy
as a generic tag, allowing generics to be used and
resolved by PHPStan. Therefore the type annotations
on class properties or function results are now re-added.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #96713: Fix incorrect Prophecy usagesClosed2022-01-31

Actions
Actions #1

Updated by Benjamin Franzke about 2 years ago

  • Related to Task #96173: Remove hideIfNotTranslated and hideIfDefaultLanguage methods added
Actions #2

Updated by Benjamin Franzke about 2 years ago

  • Related to deleted (Task #96173: Remove hideIfNotTranslated and hideIfDefaultLanguage methods)
Actions #3

Updated by Benjamin Franzke about 2 years ago

  • Related to Bug #96713: Fix incorrect Prophecy usages added
Actions #4

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73259

Actions #5

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73263

Actions #6

Updated by Benjamin Franzke about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF