Project

General

Profile

Actions

Bug #96713

closed

Fix incorrect Prophecy usages

Added by Oliver Klee almost 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
Start date:
2022-01-31
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

- remove almost as many Prophecy-related warnings from the PHPStan baseline as possible
- fix incorrect type annotations for prophecies
- use native type annotations for prophecies
- remove redundant type annotations with Prophecy that are already covered by the PHPStan Prophecy plugin


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #96725: Use generics for ObjectProphecy class propertiesClosed2022-02-01

Actions
Actions #1

Updated by Oliver Klee almost 3 years ago

  • Subject changed from Fix incorrect Prophecy usage to Fix incorrect Prophecy usages
Actions #2

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73238

Actions #3

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73238

Actions #4

Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73238

Actions #5

Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73238

Actions #6

Updated by Gerrit Code Review almost 3 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73238

Actions #7

Updated by Oliver Klee almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73257

Actions #9

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73257

Actions #10

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73257

Actions #11

Updated by Oliver Klee almost 3 years ago

  • Status changed from Under Review to Resolved
Actions #12

Updated by Benjamin Franzke almost 3 years ago

  • Related to Task #96725: Use generics for ObjectProphecy class properties added
Actions #13

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF