Project

General

Profile

Actions
Copy link

Bug #97141

closed

rte_ckeditor and its problems with custom classes

Added by Philipp Kitzberger over 2 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2022-03-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
rte_ckeditor
Complexity:
Is Regression:
Sprint Focus:

Description

In a recent TYPO3 10 project we've identified 3 problems with the ckeditor, all related to the styles/classes feature.

Problem 1: Tag breadcrumbs don't show class attributes
I remember from the old EXT:rte_htmlarea that the "tag breadcrumbs" line below the editor did mention the class attribute any tag had attached to. That's not the case for ckeditor though ;-/

Problem 2: Class attributes cannot be removed/cleared
Once a class attribute had been attached to a tag via the "Styles" select field, it's not possible (without switching to the source mode) to remove that class again ;-/

Problem 3: Multi-element classes are not auto-selected
Usually when focusing a tag the attached style is being selected in the "Styles" select field. That's not working for styles that are definied for more than one element.

Working Not working 
- { name: "Cell: Yellow 1",
    element: "th",
    attributes: { 'class': 'yellow-1' }}
 
- { name: "Cell: Yellow 2",
    element: ["td","th"],
    attributes: { 'class': 'yellow-2' }}

Summary: these three problems prevent the users from having a good UX regarding style/class selector and make them manually modify the RTE source (which we don't want!)

Files

Download all files
Bildschirmfoto vom 2022-03-08 09-39-04.png (17.4 KB) Bildschirmfoto vom 2022-03-08 09-39-04.png Philipp Kitzberger, 2022-03-08 08:40
Bildschirmfoto vom 2022-03-08 09-39-46.png (17.5 KB) Bildschirmfoto vom 2022-03-08 09-39-46.png Philipp Kitzberger, 2022-03-08 08:40
Bildschirmfoto vom 2022-03-08 09-39-18.png (14.9 KB) Bildschirmfoto vom 2022-03-08 09-39-18.png Philipp Kitzberger, 2022-03-08 08:46
Actions
Copy link
 #2

Updated by Philipp Kitzberger over 1 year ago

Update for TYPO3 11:

  • Problem 2 ("Class attributes cannot be removed/cleared") seems to be fixed.
  • The other two problem are still present ;-(
Actions
Copy link
 #3

Updated by Benni Mack 5 months ago

  • Status changed from New to Needs Feedback

Hey Philipp,

can you re-try with v12? We've updated CKEditor (= a new engine), and handles this part complettely different.

Actions
Copy link
 #4

Updated by Philipp Kitzberger 5 months ago

  • % Done changed from 0 to 100

Update for TYPO3 12:

  • Problem 1 ("Tag breadcrumbs don't show class attributes"): the tag hierarchy feature seems to be gone entirely. Guess there's not much we can do about that. So switching to source-mode is now necessary to view a node's classes.
  • Problem 2 ("Class attributes cannot be removed/cleared") is still fixed.
  • Problem 3 ("Multi-element classes are not auto-selected") is fixed!

Issue can be closed now, I think.

Actions
Copy link
 #5

Updated by Georg Ringer 5 months ago

  • Status changed from Needs Feedback to Closed

closed as requested, thanks for your feedback

Actions
Copy link

Also available in: Atom PDF