Project

General

Profile

Actions

Bug #97295

closed

TYPO3 core package replaces Symfony polyfills

Added by Helmut Hummel over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2022-04-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

While Symfony documents, that those polyfills could be replaced https://github.com/symfony/polyfill/#design
it does not mean that libraries should do so. In fact, even when documented by Symfony, adding a replace to a package, that in fact does not replace the functionality works, but is semantically still wrong.

This "hack" is quite acceptable for a concrete project, but should not be applied for libraries.

It is enough to declare PHP version constraints and leave it to concrete projects to add these replaces (or not).

As such: It would be fine to keep them for typo3/cms, but they should be removed from typo3/cms-core


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #96980: Replace most symfony/polyfill-* packagesClosed2022-02-20

Actions
Actions #1

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74169

Actions #2

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74169

Actions #3

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74169

Actions #4

Updated by Christian Kuhn over 2 years ago

  • Related to Task #96980: Replace most symfony/polyfill-* packages added
Actions #5

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74169

Actions #6

Updated by Helmut Hummel over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF