Project

General

Profile

Actions

Feature #97451

closed

Epic #88027: Properly handle Hooks/Signals and Events

Replace hooks in BackendController

Added by Benni Mack about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2022-04-22
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Provider an Event for
  • renderPostProcess
  • renderPreProcess
and remove the others
  • constructPostProcess
  • method addCss()

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #99835: AutoCreateRedirect and AutoUpdateSlug information model is not shown after page slug changeClosedStefan Bürk2023-02-05

Actions
Actions #1

Updated by Larry Garfield almost 2 years ago

What is the point of renderPreProcess? The current hook passes no data along, so I don't know what anyone could do with it. renderPostProcess lets others modify the content string, that much is self-evident, but I don't see what an RenderPreProcessEvent (or equivalent) would do. Does that mean it should be removed? If not, what would the empty event be documented as doing?

Actions #2

Updated by Benni Mack almost 2 years ago

Larry Garfield wrote in #note-1:

What is the point of renderPreProcess? The current hook passes no data along, so I don't know what anyone could do with it. renderPostProcess lets others modify the content string, that much is self-evident, but I don't see what an RenderPreProcessEvent (or equivalent) would do. Does that mean it should be removed? If not, what would the empty event be documented as doing?

You can have an EventListener that instantiates PageRenderer (which is a singleton) to inject custom CSS / JS in there.

Actions #3

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #4

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #5

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #6

Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74809

Actions #7

Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #8

Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #9

Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #10

Updated by Gerrit Code Review almost 2 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #11

Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #12

Updated by Gerrit Code Review almost 2 years ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #13

Updated by Gerrit Code Review almost 2 years ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #14

Updated by Gerrit Code Review almost 2 years ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #15

Updated by Gerrit Code Review almost 2 years ago

Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #16

Updated by Gerrit Code Review almost 2 years ago

Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #17

Updated by Gerrit Code Review almost 2 years ago

Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #18

Updated by Gerrit Code Review almost 2 years ago

Patch set 15 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797

Actions #19

Updated by Larry Garfield almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #20

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions #21

Updated by Stefan Bürk about 1 year ago

  • Related to Bug #99835: AutoCreateRedirect and AutoUpdateSlug information model is not shown after page slug change added
Actions

Also available in: Atom PDF