Actions

Copy link

Task #97538

closed

Switch to dart-sass

Added by Josef Glatz over 2 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Josef Glatz

Category:

Frontend

Target version:

Start date:

2022-05-03

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

Requirements¶

node-sass respectively LibSass is deprecated as stated in https://www.npmjs.com/package/node-sass
Bootstrap 5.x supports/uses dart-sass with the npm package "sass" which distributes dart-sass, the native javascript based sass solution

ToDo¶

Remove node-sass
Add dart-sass
Fix errors in actual implementation (where node-sass was not so strict)
Fix divisions with sass-migrator
Fix/Update existing 3rd party packages if they don't support dart-sass
- font-awesome
  - Version Update which supports dart-sass
  - Proper upgrade or patch as the migration from v4 to v6 is not that easy as it also has some breaking changes in the available icons

How to test¶

Build scripts must not use node-sass anymore.
npm package "sass" must not required anymore by the TYPO3 core

Actions

Copy link

Updated by Josef Glatz over 2 years ago

Description updated (diff)

Actions

Copy link

Updated by Jochen Roth over 2 years ago

Both work for me on Apple M1:

Build/Scripts/runTests.sh -s buildCss
Build/Scripts/runTests.sh -s buildJavascript

Actions

Copy link

Updated by Josef Glatz over 2 years ago

Thanks Jochen! Spooky. Looks like an problem on my environment. Ok, then the task is just to move to dart-sass do get rid of node-sass as it's deprecated ¯\_(ツ)_/¯

Actions

Copy link

Updated by Jochen Roth over 2 years ago

Maybe `Build/Scripts/runTests.sh -u` helps to update containers.
Just a shot in the dark.

Actions

Copy link

Updated by Josef Glatz over 2 years ago

Tracker changed from Epic to Task
Description updated (diff)
Status changed from New to In Progress
Assignee set to Josef Glatz
TYPO3 Version set to 12

Actions

Copy link

Updated by Josef Glatz over 2 years ago

Description updated (diff)

Actions

Copy link

Updated by Josef Glatz over 2 years ago

Description updated (diff)

Actions

Copy link

Updated by Josef Glatz over 2 years ago

Description updated (diff)

Actions

Copy link

Updated by Josef Glatz over 2 years ago

Description updated (diff)

Actions

Copy link

#10

Updated by Gerrit Code Review over 2 years ago

Status changed from In Progress to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75433

Actions

Copy link

#11

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75433

Actions

Copy link

#12

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75433

Actions

Copy link

#13