Task #97538
closedSwitch to dart-sass
100%
Description
Requirements¶
- node-sass respectively LibSass is deprecated as stated in https://www.npmjs.com/package/node-sass
- Bootstrap 5.x supports/uses dart-sass with the npm package "sass" which distributes dart-sass, the native javascript based sass solution
ToDo¶
- Remove node-sass
- Add dart-sass
- Fix errors in actual implementation (where node-sass was not so strict)
- Fix divisions with sass-migrator
- Fix/Update existing 3rd party packages if they don't support dart-sass
- font-awesome
- Version Update which supports dart-sass
- Proper upgrade or patch as the migration from v4 to v6 is not that easy as it also has some breaking changes in the available icons
- font-awesome
How to test¶
- Build scripts must not use node-sass anymore.
- npm package "sass" must not required anymore by the TYPO3 core
Updated by Jochen Roth over 2 years ago
Both work for me on Apple M1:
Build/Scripts/runTests.sh -s buildCss Build/Scripts/runTests.sh -s buildJavascript
Updated by Josef Glatz over 2 years ago
Thanks Jochen! Spooky. Looks like an problem on my environment. Ok, then the task is just to move to dart-sass do get rid of node-sass as it's deprecated ¯\_(ツ)_/¯
Updated by Jochen Roth over 2 years ago
Maybe `Build/Scripts/runTests.sh -u` helps to update containers.
Just a shot in the dark.
Updated by Josef Glatz over 2 years ago
- Tracker changed from Epic to Task
- Description updated (diff)
- Status changed from New to In Progress
- Assignee set to Josef Glatz
- TYPO3 Version set to 12
Updated by Gerrit Code Review over 2 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75433
Updated by Gerrit Code Review over 2 years ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75433
Updated by Gerrit Code Review over 2 years ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75433
Updated by Nikita Hovratov over 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 55a0663c5c803284ca6dd594f6c26337f67fa655.