Project

General

Profile

Actions

Task #97602

closed

Always call GU::trimExplode with a string parameter

Added by Oliver Klee almost 3 years ago. Updated 2 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2022-05-10
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

This avoids type errors when GeneralUtility is switched to strict mode.


Related issues 1 (0 open1 closed)

Blocked by TYPO3 Core - Bug #97960: Always call GU::trimExplode with a string parameter in EXT:extbase and EXT:fluidClosed2022-07-16

Actions
Actions #1

Updated by Oliver Klee almost 3 years ago

  • Blocks Task #97578: Mark GeneralUtility as strict added
Actions #2

Updated by Georg Ringer almost 3 years ago

  • Status changed from New to Accepted
Actions #3

Updated by Georg Ringer almost 3 years ago

  • Subject changed from Always call GU::trimeExplode with a string parameter to Always call GU::trimExplode with a string parameter
Actions #4

Updated by Oliver Klee over 2 years ago

  • Blocks deleted (Task #97578: Mark GeneralUtility as strict)
Actions #5

Updated by Oliver Klee over 2 years ago

This is not necessary (at least not for marking GU as strict): GU::trimExplode already casts the parameter to string. So this ticket can be closed.

Actions #6

Updated by Oliver Klee over 2 years ago

Ah, let's keep this open as this will become necessary once GU::trimExplode has native type declarations (and GU is marked as strict).

Actions #7

Updated by Oliver Klee over 2 years ago

There are really a lot a places to change. We should split this up:

- backend
- core
- extbase & fluid
- felogin
- frontend
- install
- recordlist
- workspaces
- everything else

Actions #8

Updated by Oliver Klee over 2 years ago

  • Tracker changed from Bug to Epic
  • TYPO3 Version deleted (12)
Actions #9

Updated by Oliver Klee over 2 years ago

  • Blocked by Bug #97960: Always call GU::trimExplode with a string parameter in EXT:extbase and EXT:fluid added
Actions #10

Updated by Benni Mack almost 2 years ago

  • Target version deleted (12 LTS)
Actions #11

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81964

Actions #12

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81964

Actions #13

Updated by Georg Ringer 2 days ago

request to close issue from author as he currently doesn't plan to work on those issues.

If you find the issue valid and want to work on that, feel free to comment or contact me on slack

Actions #14

Updated by Georg Ringer 2 days ago

  • Tracker changed from Epic to Task
  • Status changed from Under Review to Closed
  • TYPO3 Version set to 12
Actions

Also available in: Atom PDF